Skip to content

Sending data doc update #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Conversation

priyatharsan
Copy link
Contributor

For issue #812

@priyatharsan priyatharsan changed the base branch from master to source-design-merge September 4, 2018 20:55
@priyatharsan priyatharsan requested a review from cldougl September 4, 2018 21:02
@priyatharsan priyatharsan added the ReviewReady This PR is ready for review label Sep 4, 2018
Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@@ -1,6 +1,6 @@
---
name: Overwrite chart data with new data
description: The simplest and recommended way to update a chart remotely.<br><small>You can overwrite a chart's data with new data remotely, simply by including its file name in the filename kwarg.</small>
description: The simplest and recommended way to update a chart remotely.<br><small>You can overwrite a chart's data with new data remotely, simply by including its file name in the filename kwarg. <br>Note that setting a filename overwrites the entire chart (i.e., style & layout settings are not preserved).</small>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cldougl cldougl removed the ReviewReady This PR is ready for review label Oct 3, 2018
@priyatharsan priyatharsan merged commit a28bbbe into source-design-merge Oct 3, 2018
@priyatharsan priyatharsan deleted the sending-data-doc-update branch October 3, 2018 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants